<html>
<head><meta charset="utf-8"><title>looking for new reviewers · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/looking.20for.20new.20reviewers.html">looking for new reviewers</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="231794266"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/looking%20for%20new%20reviewers/near/231794266" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/looking.20for.20new.20reviewers.html#231794266">(Mar 25 2021 at 12:51)</a>:</h4>
<p>Since <a href="https://github.com/rust-lang/rust/pull/80347">https://github.com/rust-lang/rust/pull/80347</a> is more of a long-term project to spawn smaller PRs and I won't  be able to review it in the next 3 months, I'm looking for someone to take this over. The PR is solely about changing our HIR-visitor based metadata output logic with a iterate-all-<code>DefId</code>s-and-call-queries one and should not affect perf by suddenly calling more queries than were necessary before</p>



<a name="231798529"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/looking%20for%20new%20reviewers/near/231798529" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/looking.20for.20new.20reviewers.html#231798529">(Mar 25 2021 at 13:20)</a>:</h4>
<p>Looks pretty straightforward? I think I can take it over (if nobody better wants to)</p>



<a name="231799568"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/looking%20for%20new%20reviewers/near/231799568" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/looking.20for.20new.20reviewers.html#231799568">(Mar 25 2021 at 13:27)</a>:</h4>
<p>Thanks!</p>



<a name="231799780"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/looking%20for%20new%20reviewers/near/231799780" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jack Huey <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/looking.20for.20new.20reviewers.html#231799780">(Mar 25 2021 at 13:28)</a>:</h4>
<p>I will reassign it to me, but if anyone "better suited" wants to review it instead, just change it :)</p>



<a name="231799791"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/looking%20for%20new%20reviewers/near/231799791" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oli <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/looking.20for.20new.20reviewers.html#231799791">(Mar 25 2021 at 13:28)</a>:</h4>
<blockquote>
<p>Looks pretty straightforward?</p>
</blockquote>
<p>Yea, it's very mechanical, though sometimes nontivial to find out exactly how to prevent additional query calls. But I guess that is up to the author to find out <span aria-label="upside down" class="emoji emoji-1f643" role="img" title="upside down">:upside_down:</span></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>